[PATCH] regex: fix buffer read overrun in search [BZ#28470]
Paul Eggert
eggert@cs.ucla.edu
Fri Nov 26 18:35:04 GMT 2021
On 11/25/21 01:01, Andreas Schwab wrote:
>> Partly because it refuses to read past the bounds of an array, where the
>> old code would.
>
> That's just papering over a bug, not fixing it.
That's not clear to me. Perhaps you're right, but perhaps it really does
fix the bug.
>> And partly because it's been run through several tests - not just
>> glibc tests, but also grep and coreutils and probably some others by
>> now.
>
> How much coverage do they provide?
Someone who has more time could presumably determine this by looking at
the respective test suites. I forgot to mention, Gnulib also has its own
regex tests (which also pass).
> Also, you failed to add a test.
Yes, that's correct. It would be nice if someone could do that. However,
it'd be some work and like you I'm pressed for time.
More information about the Libc-alpha
mailing list