[PATCH] setjmp: Replace jmp_buf-macros.h with jmp_buf-macros.sym

Adhemerval Zanella adhemerval.zanella@linaro.org
Fri Nov 19 18:34:53 GMT 2021



On 19/11/2021 15:33, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> On 19/11/2021 15:28, Florian Weimer wrote:
>>> * Adhemerval Zanella via Libc-alpha:
>>>
>>>> diff --git a/setjmp/__setjmp_check.c b/setjmp/__setjmp_check.c
>>>> new file mode 100644
>>>> index 0000000000..4be6e432b3
>>>> --- /dev/null
>>>> +++ b/setjmp/__setjmp_check.c
>>>> @@ -0,0 +1,34 @@
>>>> +/* Check jmp_buf sizes, alignments and offsets.  */
>>>
>>> Shouldn't this be an internal test?
>>>
>>> I checked the generated constants against the removed files, and found
>>> no discrepancies, so I think this can go in.
>>
>> My understanding is the _Static_assert would be more useful at build time,
>> specially for cross-compilation.
> 
> An internal will still have the same effect when cross-compiled.

I don't have a strong preference in fact, I think an object consumes slight
less resources through (cpu time to build, disk size).


More information about the Libc-alpha mailing list