[PATCH v2] elf: Use a temporary file to generate Makefile fragments [BZ #28550]

[Florian Weimer]

* H. J. Lu:

> On Wed, Nov 17, 2021 at 5:49 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> I still see
>>
>>   /builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b5483/build-x86_64-redhat-linux/elf/dso-sort-tests-2.def.generated-makefile:1067: warning: overriding recipe for target '/builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b5483/build-x86_64-redhat-linux/elf/tst-redhat-1162810-dir/tst-redhat-1162810-M22X17.os'
>>
>> and eventually a build failure:
>>
>>   make[2]: Leaving directory '/builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b5483/elf'
>>   make[1]: *** [Makefile:483: elf/tests] Error 2
>>   make: *** [Makefile:9: check] Error 2
>>
>> There's no error before that, or other message indicating which make
>> target is failing.
>>
>> The full build log is here:
>>
>>   <https://koji.fedoraproject.org/koji/taskinfo?taskID=78987342>
>>   <https://kojipkgs.fedoraproject.org//work/tasks/7342/78987342/build.log>
>>
>> The make error messages are not very helpful to me though.
>>
>
> It also happened to me in a build directory whose path contains a
> symbolic linked directory.  Make was confused to include the generated
> makefile twice, which could be reached with 2 different pathnames.
> After removing the symbolic linked directory, the generated makefile
> can be reached with a single pathname, the make error went away.

This is a standard Koji build environment.  The build directory is not a
symbolic link:

+ readlink -f .
/builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b5483/build-x86_64-redhat-linux

And we reach that via /builddir/build/BUILD.

So I still don't know what's going on there.

Thanks,
Florian