[PATCH v6 01/20] elf: Suppress audit calls when a (new) namespace is empty (BZ #28062)

Andreas Schwab schwab@linux-m68k.org
Tue Nov 16 14:16:05 GMT 2021


On Nov 16 2021, Florian Weimer wrote:

> * Andreas Schwab:
>
>> On Nov 16 2021, Adhemerval Zanella via Libc-alpha wrote:
>>
>>> +      /* Auditing checkpoint: we are going to add new objects.  Since this
>>> +         is called after _dl_add_to_namespace_list() the namespace is
>>
>> Not a function call here.
>
> I've stopped pointing those out in patch reviews.  Is this GNU
> convention really useful?  If there is no other markup, it often
> increases readability,

You can always write "the foo function".

> particular for identifiers that are also bona fide English words, such
> as read and close.

Which only proves my point.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."


More information about the Libc-alpha mailing list