[PATCH v5 18/22] elf: Issue la_symbind() for bind-now (BZ #23734)

Adhemerval Zanella adhemerval.zanella@linaro.org
Mon Nov 15 15:54:41 GMT 2021



On 15/11/2021 11:23, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>>> I find DL_FIXUP_BINDNOW_ADDR_VALUE very confusing.  Why is it safe to
>>> extract just the code address from the function descriptor?
>>
>> That's my understanding because at this point st.st_value points to code
>> address, not OPD address.
> 
> But the resulting function descriptor will not contain the right TOC
> address, I think.

Right, we need to update the toc in such case, as elf_machine_fixup_plt
does for _dl_fixup. I will fix it.


More information about the Libc-alpha mailing list