[PATCH v8 1/2] elf: Testing infrastructure for ld.so DSO sorting (BZ #17645)

[H.J. Lu]

On Fri, Nov 5, 2021 at 7:00 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Fri, Nov 5, 2021 at 6:47 AM Florian Weimer <fweimer@redhat.com> wrote:
> >
> > * H. J. Lu via Libc-alpha:
> >
> > >> +# DSO sorting tests:
> > >> +# The dso-ordering-test.py script generates testcase source files in $(objpfx),
> > >> +# creating a $(objpfx)<testcase-name>-dir for each testcase, and creates a
> > >> +# Makefile fragment to be included.
> > >> +define include_dsosort_tests
> > >> +$(objpfx)$(1).generated-makefile: $(1)
> > >> +       $(PYTHON) $(..)scripts/dso-ordering-test.py \
> > >> +       --description-file $$< --objpfx $(objpfx) --output-makefile $$@
> > >> +include $(objpfx)$(1).generated-makefile
> > >> +endef
> > >> +
> > >> +# Generate from each testcase description file
> > >> +$(eval $(call include_dsosort_tests,dso-sort-tests-1.def))
> > >> +$(eval $(call include_dsosort_tests,dso-sort-tests-2.def))
> > >> +
> > >
> > > I don't think it works with parallel build on many-core machines.
> > > I think it should be changed to use configure.ac or Makeconfig
> > > to generate these makefile fragments, similar to
> > >
> > > https://sourceware.org/git/?p=glibc.git;a=commit;h=d962cce139583c71fcbe9a05dc4c5fa68f72f655
> > >
> > > I opened:
> > >
> > > https://sourceware.org/bugzilla/show_bug.cgi?id=28550
> >
> > Probably this needs to be:
> >
> > define include_dsosort_tests
> > $(objpfx)$(1).generated-makefile: $(1)
> >        $(PYTHON) $(..)scripts/dso-ordering-test.py \
> >        --description-file $$< --objpfx $(objpfx) --output-makefile $$@T
> >        mv $$@T $$@
> > include $(objpfx)$(1).generated-makefile
> > endef
> >
> > So that make doesn't read a partial file.
>
> This may work.  But using Makeconfig is safer.

It doesn't work.

>
> --
> H.J.



-- 
H.J.