[PATCH v2 2/6] Benchtests: Add benchtests for __memcmpeq

Wilco Dijkstra Wilco.Dijkstra@arm.com
Wed Nov 3 13:39:29 GMT 2021


Hi Noah,

> > As committed, it's literally the same benchmark as memcmp, however I
> > expected it to call __memcmpeq... You'll need to change the definition of
> > MEMCMP as well.

> Not certain why, but it does seem to be getting the right ifuncs. Can update it
> if desirable.

> Is this also true for 'wmemcmp'? I don't see it defining MEMCMP either.

Ifuncs use TEST_NAME (which is right) while there is also IMPL (MEMCMP, 1)
which is not correct. It is defined in bench-string - it does support wmemcmp,
but it is missing support for __memcmpeq.

Cheers,
Wilco


More information about the Libc-alpha mailing list