[PATCH v2] tst-tzset: output reason when creating 4GiB file fails
Stafford Horne
shorne@gmail.com
Tue Nov 2 23:31:59 GMT 2021
Currently, if the temporary file creation fails the create_tz_file
function returns NULL. The NULL pointer is then passed to setenv which
causes a SIGSEGV. Rather than failing with a SIGSEGV print a warning
and exit.
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
---
Changes since v1:
- Use PRId64 printf formatting, suggested by Adhemerval
timezone/tst-tzset.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
index d6da2932bb..3dad42e041 100644
--- a/timezone/tst-tzset.c
+++ b/timezone/tst-tzset.c
@@ -25,6 +25,7 @@
#include <time.h>
#include <unistd.h>
#include <support/check.h>
+#include <inttypes.h>
static int do_test (void);
#define TEST_FUNCTION do_test ()
@@ -103,6 +104,13 @@ static void
test_tz_file (off64_t size)
{
char *path = create_tz_file (size);
+ if (path == NULL)
+ {
+ printf ("creating timezone file of size: %" PRId64 "MiB failed.\n",
+ size / (1024 * 1024));
+ exit (1);
+ }
+
if (setenv ("TZ", path, 1) < 0)
{
printf ("setenv failed: %m\n");
--
2.31.1
More information about the Libc-alpha
mailing list