[PATCH 06/11] nptl: Install cancellation handler on pthread_cancel

Adhemerval Zanella adhemerval.zanella@linaro.org
Wed May 26 17:52:04 GMT 2021



On 26/05/2021 14:38, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
> 
>> @@ -134,7 +135,11 @@ __pthread_cancel (pthread_t th)
>>  	       call pthread_cancel (pthread_self ()) without calling
>>  	       pthread_create, so the signal handler may not have been
>>  	       set up for a self-cancel.  */
>> -	    sigcancel_handler ();
>> +            {
>> +              THREAD_SETMEM (pd, result, PTHREAD_CANCELED);
>> +              if ((newval & CANCELTYPE_BITMASK) != 0)
>> +	        __do_cancel ();
>> +            }
> 
> The comment is no longer up to date, I think.  Rest of the change looks
> okay to me.

Indeed, I will remove it.


More information about the Libc-alpha mailing list