[PING][PATCH] charmap_conversion: Free conversion table on exit

Siddhesh Poyarekar siddhesh@sourceware.org
Mon May 17 15:59:49 GMT 2021


Ping!  I'll push this one too in a couple of days if there are no 
objections since it is a pretty trivial fix.

Siddhesh

On 5/11/21 10:46 PM, Siddhesh Poyarekar via Libc-alpha wrote:
> The conversion table is allocated using xcalloc but never freed.
> ---
>   iconv/iconv_charmap.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/iconv/iconv_charmap.c b/iconv/iconv_charmap.c
> index f76b3ce2b1..e3d12b04e3 100644
> --- a/iconv/iconv_charmap.c
> +++ b/iconv/iconv_charmap.c
> @@ -228,6 +228,7 @@ charmap_conversion (const char *from_code, struct charmap_t *from_charmap,
>       while (++remaining < argc);
>   
>     /* All done.  */
> +  free (cvtbl);
>     return status;
>   }
>   
> 



More information about the Libc-alpha mailing list