[PATCH v2] Run $(objpfx)iconvconfig with $(run-program-prefix) [BZ #27477]

[H.J. Lu]

On Thu, May 6, 2021 at 8:23 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> > diff --git a/iconv/Makefile b/iconv/Makefile
> > index 659857dd8c..4af3eea0d8 100644
> > --- a/iconv/Makefile
> > +++ b/iconv/Makefile
> > @@ -95,11 +95,13 @@ $(inst_bindir)/iconv: $(objpfx)iconv_prog $(+force)
> >  $(objpfx)iconv_prog: $(iconv_prog-modules:%=$(objpfx)%.o)
> >  $(objpfx)iconvconfig: $(iconvconfig-modules:%=$(objpfx)%.o)
> >
> > -$(objpfx)test-iconvconfig.out: /dev/null $(objpfx)iconvconfig
> > +$(objpfx)test-iconvconfig.out: $(objpfx)iconvconfig
> >       (set -e; \
> >        tmp=$(objpfx)gconv-modules.cache.$$$$; \
> >        rm -f $$tmp; \
> > -      $(make-test-out) --output=$$tmp --nostdlib $(inst_gconvdir); \
> > +      $(built-program-cmd-before-env) \
> > +             $(run-program-env) $(built-program-cmd-after-env) $< \
> > +             --output=$$tmp --nostdlib $(inst_gconvdir); \
> >        cmp $$tmp $(inst_gconvdir)/gconv-modules.cache; \
> >        rm -f $$tmp) > $@; \
> >       $(evaluate-test)
>
> Should tests use $(test-wrapper-env) instead of $(run-program-env)

I think we should use

$(run-program-prefix) $(objpfx)iconvconfig

> $(built-program-cmd-after-env)?  I think it's commonly used (mostly
> along with shell scripts though).
>
> Thanks,
> Florian
>

Here is the v2 patch.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-0001-Run-objpfx-iconvconfig-with-run-program-prefix-BZ.patch
Type: text/x-patch
Size: 1858 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20210506/2297802e/attachment.bin>