[PATCH] stdio-common/printf-prs.c: Simplify test

Alejandro Colomar (man-pages) alx.manpages@gmail.com
Mon Mar 29 20:35:14 GMT 2021



On 3/29/21 9:32 PM, Adhemerval Zanella wrote:
> 
> 
> On 24/03/2021 15:07, Alejandro Colomar via Libc-alpha wrote:
>> The test was being repeated for all the remaining code in the for loop.
>> Test once, and 'continue' to next iteration if necessary, so that the
>> following code can assume that the necessary condition is met.
>>
>> Minor changes: fix some mixed tabs & spaces to use spaces only.
>>
>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> 
> We do not use SCO, but rather Copyright assignment.  And I think we will
> need to add a testcase for this change, this simple program below shows
> a complete different result with this patch applied:
> 

Hello Adhemerval,

Yes, I was completely wrong with that patch.  I submitted a patch v2
after that, trying to improve the comments (without the code changes,
which were wrong) to avoid confusion:
<https://sourceware.org/pipermail/libc-alpha/2021-March/124359.html>.

Thanks,

Alex

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/


More information about the Libc-alpha mailing list