[PATCH] S390: Don't test nanoseconds in io/tst-stat.c

Joseph Myers joseph@codesourcery.com
Wed Mar 17 21:01:08 GMT 2021


On Wed, 17 Mar 2021, Stefan Liebler via Libc-alpha wrote:

> Both new tests io/tst-stat and io/tst-stat-lfs (_FILE_OFFSET_BITS=64)
> are comparing the nanosecond fields with the statx result.  Unfortunately
> on s390(31bit) those fields are always zero if old KABI with non-LFS
> support is used.  With _FILE_OFFSET_BITS=64 stat is using statx internally.

My understanding is that, if using a kernel that supports statx, this 
disabling is not needed.

If so, we want to be sure to remove this disabling once we can assume a 
kernel supporting statx (on s390).  The way we ensure that is having a 
conditional on __ASSUME_STATX in the code in question so that it's 
immediately visible when we remove __ASSUME_STATX that this disabling can 
be removed from the glibc source code as well.

-- 
Joseph S. Myers
joseph@codesourcery.com


More information about the Libc-alpha mailing list