[PATCH 08/30] nptl: Remove send from libpthread

Florian Weimer fweimer@redhat.com
Wed Mar 17 20:13:04 GMT 2021


* Florian Weimer via Libc-alpha:

> * Adhemerval Zanella via Libc-alpha:
>
>> The libc version is identical and built with same flags.  Both aarch64
>> and nios2 also requires to export __send.  It was done previously with
>> the HAVE_INTERNAL_SEND_SYMBOL (which forced the symbol creation),
>> however it is simpler to add them on the architecture specific Version
>> script snippet.
>
> In other cases, we have said that doing this would require adding a
> __send@GLIBC_2.34 symbol (which is what my patched
> move-symbol-to-libc.py script does).
>
> However, I think we can turn this into a compat symbol in this case.
> All __send callers are internal to libc, so we don't need
> __send@GLIBC_PRIVATE, just a hidden proto.

One more comment: Please also remove:

sysdeps/unix/sysv/linux/aarch64/sysdep.h:# undef HAVE_INTERNAL_SEND_SYMBOL
sysdeps/unix/sysv/linux/nios2/sysdep.h:# undef HAVE_INTERNAL_SEND_SYMBOL

Thanks,
Florian



More information about the Libc-alpha mailing list