[PATCH 2/3] Disable stack protector for ifunc resolvers in tests

Siddhesh Poyarekar siddhesh@sourceware.org
Wed Mar 10 09:57:10 GMT 2021


On 3/10/21 3:09 PM, Florian Weimer via Libc-alpha wrote:
> * Siddhesh Poyarekar:
> 
>> On 3/10/21 1:29 PM, Florian Weimer via Libc-alpha wrote:
>>> * Siddhesh Poyarekar via Libc-alpha:
>>>
>>>> IFUNC resolvers get called too early for stack protector to be useful,
>>>> so fix the elf tests to disable stack protector for the resolver
>>>> functions.  This fixes test failures in the static tests on x86_64.
>>> With -fstack-protector-all, presumably.  Does this need a bug in
>>> Bugzilla?
>>
>> I started to file it and found there already was a report[1] and a
>> patch that fixes it.  I'll remove the overlapping hunk from my patch
>> and credit David with it and close that bug once this goes in.
> 
> Okay, please mention the bug number in the commit message then.
> (I assume there's a bug for it, [1] is dangling.)

Hah, I was just seeing if you were paying attention ;)

Siddhesh

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=25680


More information about the Libc-alpha mailing list