[PATCH v6 2/4] Fix the inaccuracy of j1f (BZ 14470) and y1f (BZ 14472)

Adhemerval Zanella adhemerval.zanella@linaro.org
Mon Mar 8 13:38:32 GMT 2021



On 06/03/2021 01:45, Paul Zimmermann wrote:
>        Dear Adhemerval,
> 
> thank you again for your review. I will prepare a new version. I have just
> one question:
> 
>> This routine is similar to the one at sysdeps/ieee754/flt-32/e_j0f.c,
>> maybe move it to a common place and define it once.
> 
> is it ok if I put the common routine, still defined as static double
> reduce_aux(), in a new file flt-32/reduce_aux.c, and I include this
> file in both e_j0f.c and e_j1f.c with #include "reduce_aux.c"?

Usually for short sized functions, you can add it as a inline implementation
and let compiler inline it or not.  For large functions I would go for a
separate module and a hidden prototype (so we can control de code size).


More information about the Libc-alpha mailing list