[PATCH 08/16] malloc: Use global flag instead of function pointer dispatch for mtag
DJ Delorie
dj@redhat.com
Fri Mar 5 00:46:46 GMT 2021
Szabolcs Nagy <szabolcs.nagy@arm.com> writes:
> The definition of tag_new_usable is moved after chunk related
> definitions.
A couple thousand lines after, that is. Perhaps it could go at the end
of the chunk related definitions, closer to the other tag functions?
> This refactoring also allows using mtag_enabled checks instead of
> USE_MTAG ifdefs when memory tagging support only changes code logic
> when memory tagging is enabled at runtime.
Are you relying on the compiler to do the work of the old #ifdefs for
platforms without USE_MTAG set? I.e. are we sure that the compiled
binaries will have the mtag-related code optimized out?
Otherwise LGTM with the above caveats.
Reviewed-by: DJ Delorie <dj@redhat.com>
More information about the Libc-alpha
mailing list