[PATCH v2] <shlib-compat.h>: Support compat_symbol_reference for _ISOMAC

[H.J. Lu]

On Tue, Mar 2, 2021 at 1:18 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Tue, Mar 2, 2021 at 1:02 PM Florian Weimer <fweimer@redhat.com> wrote:
> >
> > * H. J. Lu:
> >
> > > On Tue, Mar 2, 2021 at 12:10 PM Florian Weimer via Libc-alpha
> > > <libc-alpha@sourceware.org> wrote:
> > >>
> > >> This is helpful for testing compat symbols in cases where _ISOMAC
> > >> is activated implicitly due to -DMODULE_NAME=testsuite and cannot
> > >> be disabled easily.
> > >>
> > >> ---
> > >> v2: Now actually tested in the situation where I need it.
> > >>
> > >
> > > Any particular tests which need this?
> >
> > nptl/tst-cleanup4aux.c will need this once _pthread_cleanup_push,
> > _pthread_cleanup_pop are compatibility symbols.
> >
>
> Do you just want to link against the older version and nothing else?
>

Why are these tests OK without your patch?

malloc/tst-mallocstate.c:compat_symbol_reference (libc,
malloc_get_state, malloc_get_state, GLIBC_2_0);
malloc/tst-mallocstate.c:compat_symbol_reference (libc,
malloc_set_state, malloc_set_state, GLIBC_2_0);
posix/tst-glob_lstat_compat.c:compat_symbol_reference (libc, glob,
glob, GLIBC_2_1);
posix/tst-glob_lstat_compat.c:compat_symbol_reference (libc, glob,
glob, GLIBC_2_0);
posix/tst-spawn4-compat.c:compat_symbol_reference (libc, posix_spawn,
posix_spawn, GLIBC_2_2);
posix/tst-spawn4-compat.c:compat_symbol_reference (libc, posix_spawnp,
posix_spawnp, GLIBC_2_2);
resolv/tst-p_secstodate.c:compat_symbol_reference (libresolv,
__p_secstodate, __p_secstodate, GLIBC_2_0);
sunrpc/tst-svc_register.c:compat_symbol_reference (libc, xdr_pmap,
xdr_pmap, GLIBC_2_0);
sunrpc/tst-svc_register.c:compat_symbol_reference (libc,
svc_unregister, svc_unregister, GLIBC_2_0);
sysdeps/unix/sysv/linux/tst-ofdlocks-compat.c:compat_symbol_reference
(libc, fcntl, fcntl, GLIBC_2_0);
sysdeps/unix/sysv/linux/tst-readdir64-compat.c:compat_symbol_reference
(libc, compat_readdir64, readdir64, GLIBC_2_1);

-- 
H.J.