[PATCH v2 5/9] nptl: Move cancel state out of cancelhandling

[Florian Weimer]

* Adhemerval Zanella via Libc-alpha:

> Now that thread cancellation state is not accessed concurrently anymore,
> it is possible to move it out the 'cancelhandling'.
>
> The code is also simplified: the CANCELLATION_P is replaced with a

Drop “the”?

> internal pthread_testcancel call and the CANCELSTATE_BIT{MASK} is
> removed.
>
> The second part of this patchset also keeps the pthread_setcanceltype as
> cancellation entrypoint by calling pthread_testcancel if the new type
> is PTHREAD_CANCEL_ASYNCHRONOUS.

What do you mean by “patchset” in this context?  It's in the same
commit, right?

> With this behavior pthread_setcancelstate does not require to act on
> cancellation if cancel type is asynchronous (is already handled either
> by pthread_setcanceltype or by the signal handler).

Is this really true?  What is supposed to happen with a pending
asynchronous cancellation request if cancellation is disabled for the
target thread?  Isn't it supposed to be queued if it's a self-cancel?

Thanks,
Florian