[PATCH 30/30] nss: Directly load nss_dns, without going through dlsym/dlopen

Carlos O'Donell carlos@redhat.com
Thu Jul 15 12:21:14 GMT 2021


On 7/15/21 3:09 AM, Florian Weimer wrote:
> * Carlos O'Donell:
> 
>>> diff --git a/nss/nss_files_functions.c b/nss/nss_files_functions.c
>>> index 85720b4311..46040fff70 100644
>>> --- a/nss/nss_files_functions.c
>>> +++ b/nss/nss_files_functions.c
>>> @@ -34,10 +34,4 @@ __nss_files_functions (nss_module_functions_untyped pointers)
>>>  #undef DEFINE_NSS_FUNCTION
>>>  #define DEFINE_NSS_FUNCTION(x) *fptr++ = _nss_files_##x;
>>>  #include "function.def"
>>> -
>>> -#ifdef PTR_MANGLE
>>> -  void **end = fptr;
>>> -  for (fptr = pointers; fptr != end; ++fptr)
>>> -    PTR_MANGLE (*fptr);
>>> -#endif
>>
>> OK. No more PTR_MANGLE handling required because we are not loaded.
> 
> Acutually the PTR_MANGLE is moved into the caller because it is common
> between nss_dns and nss_files.

Agreed, I noticed the refactoring later, but didn't cleanup my comment.

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list