[PATCH] powerpc64: Remove strcspn ifunc from the loader

Tulio Magno Quites Machado Filho tuliom@linux.ibm.com
Thu Jul 8 21:31:53 GMT 2021


Paul E Murphy via Libc-alpha <libc-alpha@sourceware.org> writes:

> On 7/2/21 2:32 PM, Tulio Magno Quites Machado Filho via Libc-alpha wrote:
>> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcspn.c b/sysdeps/powerpc/powerpc64/multiarch/strcspn.c
>> index 683aa104d7..bb4d54620f 100644
>> --- a/sysdeps/powerpc/powerpc64/multiarch/strcspn.c
>> +++ b/sysdeps/powerpc/powerpc64/multiarch/strcspn.c
>> @@ -16,6 +16,7 @@
>>      License along with the GNU C Library; if not, see
>>      <https://www.gnu.org/licenses/>.  */
>> 
>> +#if IS_IN (libc)
>>   #include <string.h>
>>   #include <shlib-compat.h>
>>   #include "init-arch.h"
>> @@ -33,3 +34,4 @@ libc_ifunc (__libc_strcspn,
>> 
>>   weak_alias (__libc_strcspn, strcspn)
>>   libc_hidden_builtin_def (strcspn)
>> +#endif
>
> Is the macro guard needed if you're directly bypassing via 
> rtld-strcspn.c above? Otherwise, LGTM either way.

No, it isn't.
I'm removing it.

Thanks!

-- 
Tulio Magno


More information about the Libc-alpha mailing list