[PATCH 0/5] Some rtld-audit fixes

[John Mellor-Crummey]

Adhemerval,

We are delighted to see your patches for the most troublesome problems (our Tier 1 issues) in glibc 2.34!! We look forward to installing a version of glibc with these patches soon and testing them.

In your email below, you mention that the ARM bugs are not fixed with this patch set and that they will be handled in a different patch set. Are you expecting that patch set to make it into 2.34 or not?
--
John Mellor-Crummey		Professor
Dept of Computer Science	Rice University
email: johnmc@rice.edu		phone: 713-348-5179

> On Jul 7, 2021, at 1:26 PM, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
> This patchset fixes some rtld-audit issues brought by John
> Mellor-Crummey [1] while trying to use it along with the HPCToolkit
> tool.  This should cover the issues listed as 'Tier 1' [2], modulo
> the aarch64 one, which I plan to address in a different patch set.
> 
> The first patch fixes a regression issue introduced by a
> __libc_early_init() change.
> 
> The second patch is long-standing issue where the lazy resolution
> trampolines are used even when the audit modules does not implement
> the PLT or symbol binding callback.  The original patch from
> Alexander Monakov is incomplete, since it also requires to take
> la_symbind{32,64} in consideration.
> 
> The third patch add some tests to check if TLSDESC works along with
> audit modules.
> 
> The forth patch fixes an issue when a dlmopen failure in a audit
> module callback trigger an assert.
> 
> The final patch fixes another dlmopen failure when audit module
> is used along with dlmopen.  This patch was proposed along with 
> RTLD_SHARED support, so I added a regression test.
> 
> [1] https://sourceware.org/pipermail/libc-alpha/2021-June/127636.html
> [2] https://docs.google.com/document/d/1dVaDBdzySecxQqD6hLLzDrEF18M1UtjDna9gL5BWWI0/edit#
> 
> Adhemerval Zanella (4):
>  elf: Fix audit regression
>  elf: Avoid unnecessary slowdown from profiling with audit (BZ#15533)
>  elf: Add audit tests for modules with TLSDESC
>  elf: Do not fail for failed dlopem on audit modules (BZ #28061)
> 
> Vivek Das Mohapatra (1):
>  elf: Suppress audit calls when a (new) namespace is empty (BZ #28062)
> 
> elf/Makefile                   |  44 +++++++++++-
> elf/dl-load.c                  |   7 +-
> elf/dl-open.c                  |   4 +-
> elf/dl-reloc.c                 |  13 +++-
> elf/rtld.c                     |   8 +--
> elf/tst-audit-tlsdesc-audit.c  |  23 ++++++
> elf/tst-audit-tlsdesc-dlopen.c |  67 +++++++++++++++++
> elf/tst-audit-tlsdesc.c        |  60 ++++++++++++++++
> elf/tst-audit17.c              |  25 +++++++
> elf/tst-audit18a.c             |  39 ++++++++++
> elf/tst-audit18b.c             |  30 ++++++++
> elf/tst-audit18bmod.c          |  22 ++++++
> elf/tst-audit19.c              |  25 +++++++
> elf/tst-audit20.c              | 128 +++++++++++++++++++++++++++++++++
> elf/tst-audit20mod.c           |  26 +++++++
> elf/tst-auditmod-tlsdesc1.c    |  41 +++++++++++
> elf/tst-auditmod-tlsdesc2.c    |  33 +++++++++
> elf/tst-auditmod17.c           |  24 +++++++
> elf/tst-auditmod18a.c          |  25 +++++++
> elf/tst-auditmod18b.c          |  48 +++++++++++++
> elf/tst-auditmod19.c           |  57 +++++++++++++++
> elf/tst-auditmod20.c           |  73 +++++++++++++++++++
> include/link.h                 |   2 +
> 23 files changed, 810 insertions(+), 14 deletions(-)
> create mode 100644 elf/tst-audit-tlsdesc-audit.c
> create mode 100644 elf/tst-audit-tlsdesc-dlopen.c
> create mode 100644 elf/tst-audit-tlsdesc.c
> create mode 100644 elf/tst-audit17.c
> create mode 100644 elf/tst-audit18a.c
> create mode 100644 elf/tst-audit18b.c
> create mode 100644 elf/tst-audit18bmod.c
> create mode 100644 elf/tst-audit19.c
> create mode 100644 elf/tst-audit20.c
> create mode 100644 elf/tst-audit20mod.c
> create mode 100644 elf/tst-auditmod-tlsdesc1.c
> create mode 100644 elf/tst-auditmod-tlsdesc2.c
> create mode 100644 elf/tst-auditmod17.c
> create mode 100644 elf/tst-auditmod18a.c
> create mode 100644 elf/tst-auditmod18b.c
> create mode 100644 elf/tst-auditmod19.c
> create mode 100644 elf/tst-auditmod20.c
> 
> -- 
> 2.30.2
>