[PATCH 6/7] socket: Add recvmsg timestamp test

[Florian Weimer]

* Adhemerval Zanella:

> On 05/07/2021 17:02, Florian Weimer wrote:
>> * Adhemerval Zanella:
>> 
>>>>> +  do_test_send (&srv_addr, 1);
>>>>> +  do_recvmsg (srv, false, NULL, 0, 0, 0);
>>>>> +
>>>>> +  /* If underlying kernel does not support   */
>>>>> +  bool support_64_timestamp = support_socket_time64_timestamp (srv);
>>>>> +
>>>>> +  /* Enable the timestamp using struct timeval precision.  */
>>>>> +  xsetsockopt (srv, SOL_SOCKET, SO_TIMESTAMP, &(int){1}, sizeof (int));
>>>>
>>>> Please use setsockopt here, nt the x wrapper, so that the ABI switches
>>>> with time64 support.
>>>
>>> Currently it does not matter because SO_TIMESTAMP will be handled by
>>> the kernel headers.
>> 
>> With my __setsockopt64 patch, the time64 version of the test will use a
>> different symbol.  This is what I meant.
>
> Yeah, I am not really convinced we do need such newer symbols that do
> not correlate to 64-bit time_t syscall since I think it is *highly* 
> unlikely kernel will 64-bit time_t facilities for multiplexed syscall
> (and I would consider this a bug) without any guards or checking
> if the program is using 32-bit time_t.

What about SO_VM_SOCKETS_CONNECT_TIMEOUT? 

> Florian, in any case *currently* this patch does not need to use
> xsetsockopt.  I can adapt if your set get merged first.

Fine, go with xsetsockopt then.

Thanks,
Florian