[PATCH v3 03/10] Move glibc.malloc.check implementation into its own file

Siddhesh Poyarekar siddhesh@sourceware.org
Fri Jul 2 09:29:19 GMT 2021


On 7/2/21 2:35 PM, Andreas Schwab wrote:
> On Jul 02 2021, Siddhesh Poyarekar via Libc-alpha wrote:
> 
>> diff --git a/malloc/Makefile b/malloc/Makefile
>> index c8256abbbf..47013d44aa 100644
>> --- a/malloc/Makefile
>> +++ b/malloc/Makefile
>> @@ -271,7 +271,8 @@ $(objpfx)memusage: memusage.sh
>>   
>>   
>>   # Extra dependencies
>> -$(foreach o,$(all-object-suffixes),$(objpfx)malloc$(o)): arena.c hooks.c
>> +$(foreach o,$(all-object-suffixes),$(objpfx)malloc$(o)): arena.c hooks.c \
>> +							 malloc-check.c
> 
> I don't see any need for these manual dependencies.

May I just drop all the dependencies altogether in a separate patch 
then?  I see that arena.c and hooks.c dependencies also get 
autogenerated in malloc.o{,s}.d.

Siddhesh


More information about the Libc-alpha mailing list