[PATCH] manual: Correct argument order in mount examples (bug 27207)

[DJ Delorie]

"John McCabe" <john@mccabe.org.uk> writes:
> For what it's worth, I suspect it actually invalidates the first mount 
> command in the examples in the patch; while the filesystemtype is 
> ignored when MS_REMOUNT is specified, it isn't ignored for MS_RDONLY and 
> MS_NOSUID, so I suspect something like the attached update would be more 
> appropriate

Sure, it's just an example so "better example is better" :-)

> (done using an "amend last commit";  would I be better to 
> re-do the thing?)

Nah, the "don't rewrite history" rule doesn't kick in until it's
comitted somewhere public.  Besides, the hash changes when I add my
reviewed-by anyway, I think.

> As for your additional observations, I'm happy for them to be dealt with 
> separately :-)

So be it :-)


> -mount("/dev/hdb", "/cdrom", MS_MGC_VAL | MS_RDONLY | MS_NOSUID, "");
> +mount("/dev/hdb", "/cdrom", "iso9660", MS_MGC_VAL | MS_RDONLY | MS_NOSUID, "");
>  
> -mount("/dev/hda2", "/mnt", MS_MGC_VAL | MS_REMOUNT, "");
> +mount("/dev/hda2", "/mnt", "", MS_MGC_VAL | MS_REMOUNT, "");

LGTM.

Reviewed-by: DJ Delorie <dj@redhat.com>

Committed too :-)