V4 [PATCH] <sys/platform/x86.h>: Remove the C preprocessor magic

H.J. Lu hjl.tools@gmail.com
Thu Jan 21 13:29:20 GMT 2021


On Thu, Jan 21, 2021 at 3:19 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu:
>
> > Here is the updated patch.  The public function is changed to
> >
> > /* Get a pointer to the CPU feature structure.  */
> > extern const struct cpuid_feature *__x86_get_cpuid_feature_leaf (unsigned int)
> >      __attribute__ ((pure));
> >
> > OK for master?
>
> Are you okay with this version?  I like the simplicity of the interface.

Me too.

> Can we move the GLIBC_2.33 symbol into libc.so.6?  It will be very
> unusual for an object not to be linked against libc.so.6, so I expect
> that the IFUNC resolver already won't run until after libc.so.6
> relocation (due to the relocation ordering check we have on x86).

Here is the updated patch to place __x86_get_cpuid_feature_leaf
in libc.  OK for master?

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sys-platform-x86.h-Remove-the-C-preprocessor-magic.patch
Type: text/x-patch
Size: 84078 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20210121/99962f02/attachment-0001.bin>


More information about the Libc-alpha mailing list