[PATCH] stdio-common: Add a few double formatting tests [BZ #27245]

Mike Hommey mh@glandium.org
Thu Feb 4 08:03:41 GMT 2021


On Fri, Jan 29, 2021 at 11:50:30AM -0300, Adhemerval Zanella wrote:
> 
> 
> On 27/01/2021 01:45, Mike Hommey wrote:
> > This adds tests for corner cases that I've found while implementing a
> > printf based on https://github.com/google/double-conversion/ but weren't
> > covered by the printf formatting tests in glibc (which I was using as a
> > source of test cases).
> > 
> > Copyright-paperwork-exempt: Yes
> 
> LGTM for 2.34.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
>
> (...)
> 
> Maybe bail out early in the loop, like:
> 
>   if (isnan (d))
>     continue;
>  
>   sprintf (...)

That would skip the testcount++.

Would you commit this for me? (I'm not a committer)

Thank you

Mike


More information about the Libc-alpha mailing list