[PATCH v7 14/16] elf: Add la_activity during application exit

jma14 jma14@rice.edu
Mon Dec 27 05:13:17 GMT 2021


On December 24, 2021 11:50:54 AM CST, Florian Weimer via Libc-alpha  
<libc-alpha@sourceware.org> wrote:
> * Adhemerval Zanella:
>
>> la_activity is not called during application exit, even though
>> la_objclose is.
>>
>> Checked on x86_64-linux-gnu, i686-linux-gnu, and aarch64-linux-gnu.
>
> Still looks good, thanks.

I still have a concern with this patch, the included test does not  
actually test the fix, it passes even without the changes in dl-fini.c.

I believe these two checks suffice to test the new functionality:
   - la_objclose should be called after la_activity(LA_ACT_DELETE) for  
the closed object's namespace. (Since dlclose is not used in this  
test, AFAICT la_objclose is only called during program termination.)
   - la_activity(LA_ACT_CONSISTENT) should be the last callback  
received for every namespace.

-Jonathon




More information about the Libc-alpha mailing list