[PATCH v6 19/20] elf: Fix runtime linker auditing on aarch64 (BZ #26643)

Adhemerval Zanella adhemerval.zanella@linaro.org
Tue Dec 21 17:03:48 GMT 2021



On 21/12/2021 11:54, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>>>> At least for aarch64 old audit modules are error-prone and potentially adds
>>>> more subtle issues since they do not save/restore some return register that
>>>> I don't see any real gain to keep supporting them.
>>>
>>> I disagree.  la_objsearch alone is a significant use case, and I don't
>>> see why it wouldn't work today.  It does not need any
>>> architecture-specific code whatsoever.
>>
>> My main problem is provide a API which undocumented and missing support
>> where if users tries to replicate what other architecture does it will
>> shoot in the foot.  I think this is just a broken API and we should
>> avoid it.
> 
> Sorry, which API?

THe audit modules one, making la_objsearch work when the rest of the possible
callbacks functions might trigger undefined behavior (as per BZ#26643) does
not seems to me as as good way forward.  It has not bitten us before because
the user case is quite limited.


More information about the Libc-alpha mailing list