[PATCH v4 0/1] Add vector math function acos/acosf to libmvec

Joseph Myers joseph@codesourcery.com
Mon Dec 20 22:57:07 GMT 2021


On Mon, 20 Dec 2021, Cornea, Marius via Libc-alpha wrote:

> We put a lot of effort in making the changes you requested a few weeks 
> ago, and we thought those were sufficient.

A few weeks ago, there was no mention in the patch submission that this 
was generated code at all.  So naturally I reviewed the code on the basis 
that it was source code as defined in LGPLv2.1.  Likewise, I assumed for 
the original libmvec submission that it was a good-faith submission of 
free software source code.

Now that the issue has been raised of the code coming out of a compiler, 
there is a much higher review bar to be met to demonstrate that it is 
nevertheless in the preferred form for modification - because the default 
assumption that has to be overcome is that the output of a compiler is 
*not* source code, and if it is not source code, it is not free software 
and it is not acceptable for glibc.

-- 
Joseph S. Myers
joseph@codesourcery.com


More information about the Libc-alpha mailing list