[PATCH v4 0/1] Add vector math function acos/acosf to libmvec

Joseph Myers joseph@codesourcery.com
Mon Dec 20 22:19:24 GMT 2021


On Mon, 20 Dec 2021, Cornea, Marius via Libc-alpha wrote:

> I am sorry, but the original code was written in an internal Intel 
> format used to generate multiple math libraries (not just SVML), and is 
> not written in a human-readable format, unless one has extensive 
> knowledge of relevant Intel processes. As such, it cannot be shared - it 
> would not help at all.

That doesn't convince me that the assembly code proposed now is source 
code (the preferred form for modifications).  If you can't demonstrate 
that via showing the extent of manual modifications to the output is 
sufficient that the output has become the preferred form for further 
modifications, you'll need to find some other way to demonstrate that this 
contribution actually consists of source code and is free software at all.

> The situation was the same with our previous libmvec contribution, of 2016.

Well, if it turns out that's not actually the preferred form for 
modifications, we'll need to remove it from all glibc branches with that 
code on (and replace it with dumb wrappers round scalar functions to 
preserve the ABI, I suppose).

-- 
Joseph S. Myers
joseph@codesourcery.com


More information about the Libc-alpha mailing list