[PATCH v6 19/20] elf: Fix runtime linker auditing on aarch64 (BZ #26643)

Florian Weimer fweimer@redhat.com
Mon Dec 20 21:32:36 GMT 2021


* Adhemerval Zanella:

> diff --git a/elf/rtld.c b/elf/rtld.c
> index 29a37f51d3..1a13ae6314 100644
> --- a/elf/rtld.c
> +++ b/elf/rtld.c
> @@ -990,10 +990,10 @@ file=%s [%lu]; audit interface function la_version returned zero; ignored.\n",
>        return;
>      }
>  
> -  if (lav > LAV_CURRENT)
> +  if (lav != LAV_CURRENT)
>      {
>        _dl_debug_printf ("\
> -ERROR: audit interface '%s' requires version %d (maximum supported version %d); ignored.\n",
> +ERROR: audit interface '%s' requires version %d (current supported version %d); ignored.\n",
>  			name, lav, LAV_CURRENT);
>        unload_audit_module (dlmargs.map, original_tls_idx);
>        return;

Sorry, this is not what I had in mind.  I'd like to increase LAV_CURRENT
and pretend that the old and new versions have the same behavior, at
least as far as aarch64 is concerned.  We need not write the
compatibility code for the old <link.h> at this time, only if there
actual users out there that demand it.

(However, for the symbind change, I think we should look at the audit
module version.  It is also much easier to implement both behaviors
there, I hope.)

Thanks,
Florian



More information about the Libc-alpha mailing list