[PATCH] elf: Inline do_tunable_update_val/tunable_initialize [BZ #28712]

H.J. Lu hjl.tools@gmail.com
Sat Dec 18 20:28:06 GMT 2021


On Sat, Dec 18, 2021 at 12:14 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Dez 18 2021, H.J. Lu via Libc-alpha wrote:
>
> > diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c
> > index 497e948f1c..294ad81200 100644
> > --- a/elf/dl-tunables.c
> > +++ b/elf/dl-tunables.c
> > @@ -92,7 +92,7 @@ get_next_env (char **envp, char **name, size_t *namelen, char **val,
> >    return NULL;
> >  }
> >
> > -static void
> > +static void inline
> >  do_tunable_update_val (tunable_t *cur, const tunable_val_t *valp,
> >                      const tunable_num_t *minp,
> >                      const tunable_num_t *maxp)
>
> That shouldn't make a difference since static functions are already
> inlineable.  If you want to force inlining you need to use
> always_inline.
>

Fixed in the v2 patch.

Thanks.

-- 
H.J.


More information about the Libc-alpha mailing list