[PATCH v6 09/20] elf: Add _dl_audit_pltexit

Adhemerval Zanella adhemerval.zanella@linaro.org
Fri Dec 17 19:02:00 GMT 2021



On 17/12/2021 14:43, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> +#if (!ELF_MACHINE_NO_RELA && !defined ELF_MACHINE_PLT_REL) \
>> +    || ELF_MACHINE_NO_REL
>> +# define PLTREL  ElfW(Rela)
>> +#else
>> +# define PLTREL  ElfW(Rel)
>> +#endif
> 
> Can you move this definition into some shared header, so that
> elf/dl-runtime.c and elf/dl-audit.c can use a single definition?
> 
> I have looked at the actual _dl_audit_pltexit function introduction, and
> it looks okay.  But I'd review this again as part of a repost, actually
> applying the patch.

I recall why I haven't done it: it is mainly because it requires the
dl-machine.h definition and this header is kinda tricky to include.

I will check if we can move to a common header.


More information about the Libc-alpha mailing list