[PATCH v3 03/13] or1k: ABI Implementation

Adhemerval Zanella adhemerval.zanella@linaro.org
Wed Dec 15 01:15:04 GMT 2021



On 14/12/2021 19:43, Joseph Myers wrote:
> On Tue, 14 Dec 2021, Adhemerval Zanella via Libc-alpha wrote:
> 
>> +if test "x$profile" != xno; then
>> +  if test "x$with_profile" == xno; then
>> +    AC_MSG_ERROR([ABI does not support profiling])
> 
> Using == in test is a bashism.
> 
> I'd expect such a change to require the build-many-glibcs.py configuration 
> for OpenRISC to use --disable-profile.
> 

I ended up mixing up things and what or1k does not support is LD_PROFILE
instead of --enable-profile.  In this case I am not sure if it would
be better to just not enable it (by ignoring the LD_PROFILE handling
in rtld.c or dl-support.c) and emitting a warning or by just dumping
and error at process initialization.


More information about the Libc-alpha mailing list