[PATCH] linux: Add generic ioctl implementation

[Adhemerval Zanella]

On 29/11/2021 12:23, Paul A. Clarke wrote:
> On Fri, Nov 19, 2021 at 04:58:52PM -0300, Adhemerval Zanella via Libc-alpha wrote:
>> The powerpc is refactor to use the default implementation.
>> ---
> [snip]
>> diff --git a/sysdeps/unix/sysv/linux/powerpc/internal-ioctl.h b/sysdeps/unix/sysv/linux/powerpc/internal-ioctl.h
>> new file mode 100644
>> index 0000000000..3a2adce7c3
>> --- /dev/null
>> +++ b/sysdeps/unix/sysv/linux/powerpc/internal-ioctl.h
>> @@ -0,0 +1,46 @@
>> +/* Linux internal definitions for ioctl.
>> +   Copyright (C) 2021 Free Software Foundation, Inc.
>> +   This file is part of the GNU C Library.
>> +
>> +   The GNU C Library is free software; you can redistribute it and/or
>> +   modify it under the terms of the GNU Lesser General Public
>> +   License as published by the Free Software Foundation; either
>> +   version 2.1 of the License, or (at your option) any later version.
>> +
>> +   The GNU C Library is distributed in the hope that it will be useful,
>> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> +   Lesser General Public License for more details.
>> +
>> +   You should have received a copy of the GNU Lesser General Public
>> +   License along with the GNU C Library.  If not, see
>> +   <https://www.gnu.org/licenses/>.  */
>> +
>> +#include <termios.h>
>> +
>> +static inline bool
>> +__ioctl_arch (int *r, int fd, unsigned long request, void *arg)
>> +{
>> +  switch (request)
>> +    {
>> +    case TCGETS:
>> +      *r = __tcgetattr (fd, (struct termios *) arg);
>> +      break;
>> +
>> +    case TCSETS:
>> +      *r = __tcsetattr (fd, TCSANOW, (struct termios *) arg);
>> +      break;
>> +
>> +    case TCSETSW:
>> +      *r = __tcsetattr (fd, TCSADRAIN, (struct termios *) arg);
>> +      break;
>> +
>> +    case TCSETSF:
>> +      *r = __tcsetattr (fd, TCSAFLUSH, (struct termios *) arg);
>> +      break;
>> +
>> +    default:
>> +      return false;
>> +    }
>> +  return true;
>> +}
>> diff --git a/sysdeps/unix/sysv/linux/powerpc/ioctl.c b/sysdeps/unix/sysv/linux/powerpc/ioctl.c
>> deleted file mode 100644
>> index a81c7ba54c..0000000000
>> --- a/sysdeps/unix/sysv/linux/powerpc/ioctl.c
>> +++ /dev/null
>> @@ -1,68 +0,0 @@
>> -/* Copyright (C) 1998-2021 Free Software Foundation, Inc.
>> -   This file is part of the GNU C Library.
>> -
>> -   The GNU C Library is free software; you can redistribute it and/or
>> -   modify it under the terms of the GNU Lesser General Public
>> -   License as published by the Free Software Foundation; either
>> -   version 2.1 of the License, or (at your option) any later version.
>> -
>> -   The GNU C Library is distributed in the hope that it will be useful,
>> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> -   Lesser General Public License for more details.
>> -
>> -   You should have received a copy of the GNU Lesser General Public
>> -   License along with the GNU C Library; if not, see
>> -   <https://www.gnu.org/licenses/>.  */
>> -
>> -#include <stdarg.h>
>> -#include <termios.h>
>> -#include <unistd.h>
>> -#include <sys/ioctl.h>
>> -#include <sysdep.h>
>> -
>> -/* The user-visible size of struct termios has changed.  Catch ioctl calls
>> -   using the new-style struct termios, and translate them to old-style.  */
> 
> I don't know the history here, but the above comment did not move
> to the new location. Should it be preserved?

Agreed, I have adjusted locally.