[PATCH] Make using non-default as/ld/etc easier.

[Mike Frysinger]

On 23 Aug 2021 21:17, Olivier Galibert wrote:

just nits.  idea looks fine to me.

> --- a/aclocal.m4
> +++ b/aclocal.m4
> @@ -114,15 +114,38 @@ if test -n "$path_binutils"; then
>      path_binutils=`(cd $path_binutils; pwd) | sed 's%/*$%/%'`
>      CC="$CC -B$path_binutils"
>  fi
> -AS=`$CC -print-prog-name=as`
> -LD=`$CC -print-prog-name=ld`
> -AR=`$CC -print-prog-name=ar`
> +check_as_version=0
> +AC_ARG_VAR([AS], [as program to use])
> +if test -z "$AS"; then
> +    AS=`$CC -print-prog-name=as`
> +    check_as_version=1
> +fi

we do 2 space indents

(i know the CC code above is broken, but best to not keep adding more)

> --- a/configure.ac
> +++ b/configure.ac
>
> +# Accept binutils 2.25 or newer.  Don't check version if the path is forced.

we've been inconsistent, but should use "dnl" instead of "#"

> +AS_IF([test $check_as_version == 1],
> +AS_IF([test $check_ld_version == 1],

== is a bashism.  you want = instead.
-mike