[PATCH] Remove sysdeps/*/tls-macros.h

Szabolcs Nagy szabolcs.nagy@arm.com
Wed Aug 18 15:59:48 GMT 2021


The 08/16/2021 12:34, Fāng-ruì Sòng via Libc-alpha wrote:
> On Mon, Aug 16, 2021 at 12:27 PM Fangrui Song <maskray@google.com> wrote:
> >
> > They provide TLS_GD/TLS_LD/TLS_IE/TLS_IE macros for TLS testing.  Now that we
> > have migrated to __thread and tls_model attributes, these macros are unused
> > and thetls-macros.h files can retire.
> > ---
> >  sysdeps/aarch64/tls-macros.h           |  51 ---------
> >  sysdeps/alpha/tls-macros.h             |  25 -----
> >  sysdeps/arc/tls-macros.h               |  47 --------
> >  sysdeps/arm/tls-macros.h               |  72 -------------
> >  sysdeps/csky/abiv2/tls-macros.h        |  55 ----------
> >  sysdeps/generic/tls-macros.h           |  12 ---
> >  sysdeps/hppa/tls-macros.h              | 114 --------------------
> >  sysdeps/i386/tls-macros.h              |  47 --------
> >  sysdeps/ia64/tls-macros.h              |  66 ------------
> >  sysdeps/m68k/tls-macros.h              |  68 ------------
> >  sysdeps/microblaze/tls-macros.h        |  46 --------
> >  sysdeps/mips/tls-macros.h              | 130 ----------------------
> >  sysdeps/nios2/tls-macros.h             |  46 --------
> >  sysdeps/powerpc/powerpc32/tls-macros.h |  49 ---------
> >  sysdeps/powerpc/powerpc64/tls-macros.h |  42 --------
> >  sysdeps/powerpc/tls-macros.h           |   3 -
> >  sysdeps/riscv/tls-macros.h             |  47 --------
> >  sysdeps/s390/s390-32/tls-macros.h      | 106 ------------------
> >  sysdeps/s390/s390-64/tls-macros.h      |  90 ----------------
> >  sysdeps/sh/tls-macros.h                | 143 -------------------------
> >  sysdeps/sparc/sparc32/tls-macros.h     |  66 ------------
> >  sysdeps/sparc/sparc64/tls-macros.h     |  65 -----------
> >  sysdeps/x86_64/tls-macros.h            |  39 -------
> >  23 files changed, 1429 deletions(-)
> >  delete mode 100644 sysdeps/aarch64/tls-macros.h
> >  delete mode 100644 sysdeps/alpha/tls-macros.h
> >  delete mode 100644 sysdeps/arc/tls-macros.h
> >  delete mode 100644 sysdeps/arm/tls-macros.h
> >  delete mode 100644 sysdeps/csky/abiv2/tls-macros.h
> >  delete mode 100644 sysdeps/generic/tls-macros.h
> >  delete mode 100644 sysdeps/hppa/tls-macros.h
> >  delete mode 100644 sysdeps/i386/tls-macros.h
> >  delete mode 100644 sysdeps/ia64/tls-macros.h
> >  delete mode 100644 sysdeps/m68k/tls-macros.h
> >  delete mode 100644 sysdeps/microblaze/tls-macros.h
> >  delete mode 100644 sysdeps/mips/tls-macros.h
> >  delete mode 100644 sysdeps/nios2/tls-macros.h
> >  delete mode 100644 sysdeps/powerpc/powerpc32/tls-macros.h
> >  delete mode 100644 sysdeps/powerpc/powerpc64/tls-macros.h
> >  delete mode 100644 sysdeps/powerpc/tls-macros.h
> >  delete mode 100644 sysdeps/riscv/tls-macros.h
> >  delete mode 100644 sysdeps/s390/s390-32/tls-macros.h
> >  delete mode 100644 sysdeps/s390/s390-64/tls-macros.h
> >  delete mode 100644 sysdeps/sh/tls-macros.h
> >  delete mode 100644 sysdeps/sparc/sparc32/tls-macros.h
> >  delete mode 100644 sysdeps/sparc/sparc64/tls-macros.h
> >  delete mode 100644 sysdeps/x86_64/tls-macros.h
> 
> My local commit also deletes tls-macro.h lines from
> benchtests/strcoll-inputs/filelist#en_US.UTF-8.
> 
> Sorry, the sent diff does not include them.
> 
> rg -w tls-macros.h -g '!out' -g '!ChangeLog*'
> rg -w TLS_LD -g '!out' -g '!ChangeLog*' # and TLS_GD TLS_IE TLS_LE
> 
> have no result.

I think this is OK with those changes. thanks.

Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>


More information about the Libc-alpha mailing list