[PATCH v3] elf: Drop elf/tls-macros.h in favor of __thread and tls_model attributes [BZ #28152] [BZ #28205]

[Szabolcs Nagy]

The 08/12/2021 11:39, Fangrui Song via Libc-alpha wrote:
> elf/tls-macros.h was added for TLS testing when GCC did not support
> __thread. __thread and tls_model attributes are mature now and have been
> used by many newer tests.
> 
> Also delete tst-tls2.c which tests .tls_common which is unused by modern
> GCC and unsupported by Clang/LLD. .tls_common and .tbss definition are
> almost identical after linking, so the runtime test doesn't add
> additional coverage.  Assembler and linker tests should be on the
> binutils side.
> 
> When LLD 13.0.0 is allowed in configure.ac
> (https://sourceware.org/pipermail/libc-alpha/2021-August/129866.html),
> `make check` result is on par with glibc built with GNU ld.
> 
> As a future clean-up, TLS_GD/TLS_LD/TLS_IE/TLS_IE macros can be removed from
> sysdeps/*/tls-macros.h. We can add optional -mtls-dialect={gnu2,trad}
> tests to ensure coverage.

if tls-macros.h are no longer used then they
should be removed. can you submit a follow up
patch?

> Tested on aarch64-linux-gnu, powerpc64le-linux-gnu, and x86_64-linux-gnu.
> ---
> Changes from v1
> * Edit commit description that TLS_GD should be dropped in the future.
> 
> Changes from v2
> * Drop TLS_GD references from 2 tests under sysdeps/powerpc/
...
> --- a/elf/tst-tls1.c
> +++ b/elf/tst-tls1.c
> @@ -4,10 +4,13 @@
>  #include "tls-macros.h"

i still think this include is not needed, if that's
the case then please remove it. otherwise the patch
looks ok.

Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>