[PATCH] elf: _dl_fixup*: make @reloc_arg 64-bit safe

Vineet Gupta Vineet.Gupta1@synopsys.com
Mon Aug 2 23:18:41 GMT 2021


Hi Joseph, Adhemerval, Florian

On 7/22/21 6:58 AM, Vladimir Isaev via Libc-alpha wrote:
> On Jul 22 2021, Andreas Schwab wrote:
>>
>> On Jul 22 2021, Vladimir Isaev via Libc-alpha wrote:
>>
>>> diff --git a/elf/dl-runtime.c b/elf/dl-runtime.c
>>> index 9d0d941000..6099a44ffb 100644
>>> --- a/elf/dl-runtime.c
>>> +++ b/elf/dl-runtime.c
>>> @@ -56,7 +56,7 @@ _dl_fixup (
>>>   # ifdef ELF_MACHINE_RUNTIME_FIXUP_ARGS
>>>   	   ELF_MACHINE_RUNTIME_FIXUP_ARGS,
>>>   # endif
>>> -	   struct link_map *l, ElfW(Word) reloc_arg)
>>> +	   struct link_map *l, uintptr_t reloc_arg)
>>
>> ElfW(Addr)?
>>
> 
> We can use it, but I think that uintptr_t is more natural here because it is used
> in reloc_offset and reloc_index.

Any objections to this change - OK to commit ?

-Vineet



More information about the Libc-alpha mailing list