[PATCH v3 36/37] nptl: Move setxid broadcast implementation into libc

Adhemerval Zanella adhemerval.zanella@linaro.org
Tue Apr 6 18:54:35 GMT 2021



On 06/04/2021 15:41, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>>> +/* Copyright (C) 2002-2021 Free Software Foundation, Inc.
>>> +   This file is part of the GNU C Library.
>>> +   Contributed by Ulrich Drepper <drepper@redhat.com>, 2002.
>>
>> Remove the 'Contributed by' Line.
> 
> I prefer not to.  It's a copy of an existing file.  And in Germany,
> authors have an inalienable right to be named.

I am far from Copyright expert here, but my understanding is since
we do not add such 'Contributed by' anymore and Copyright assignment
is what matter, it should be fine to remove even this is a copy.

> 
>>> +static struct xid_command *__xidcmd;
>>
>> No need double underscore for static variables.
> 
> Okay, I've also made some of the functions static.
> 
> Thanks,
> Florian
> 


More information about the Libc-alpha mailing list