[PATCH 3/5] linux: Use statx for MIPSn64
Maciej W. Rozycki
macro@orcam.me.uk
Thu Apr 1 18:00:48 GMT 2021
On Thu, 1 Apr 2021, Adhemerval Zanella via Libc-alpha wrote:
> > Weird indentation here (which made me wonder how the ordering between &&
> > and || has been resolved so that GCC does not complain before I realised
> > it's simply misindented parenthesisation). Only caught as I saw the GIT
> > commit message though.
>
> The preprocessor indentation is confusing sometimes, but I think it should
> adjusted only slight to follow other usages:
>
> diff --git a/sysdeps/unix/sysv/linux/fstatat64.c b/sysdeps/unix/sysv/linux/fstatat64.c
> index f968e4ef05..ab25f64187 100644
> --- a/sysdeps/unix/sysv/linux/fstatat64.c
> +++ b/sysdeps/unix/sysv/linux/fstatat64.c
> @@ -137,7 +137,7 @@ fstatat64_time64_stat (int fd, const char *file, struct __stat64_t64 *buf,
>
> #if (__WORDSIZE == 32 \
> && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) \
> - || defined STAT_HAS_TIME32
> + || defined STAT_HAS_TIME32
> # define FSTATAT_USE_STATX 1
> #else
>
> Am I missing something here?
No, that's what I meant.
While using outer parentheses seems to be what the GNU Coding Standards
suggest for Emacs to indent properly, but I'm no Emacs user and we have
cases with preprocessor statements missing those, and otherwise there is
no indentation ambiguity here, so I guess this will be OK with your
amendment above.
Maciej
More information about the Libc-alpha
mailing list