[PATCH] powerpc: Protect dl_powerpc_cpu_features on INIT_ARCH() [BZ #26615]

Tulio Magno Quites Machado Filho tuliom@ascii.art.br
Tue Sep 22 20:48:51 GMT 2020


Raphael Moreira Zinsly <rzinsly@linux.ibm.com> writes:

> diff --git a/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h b/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h
> index 17ddfcf528..c8fa07fadc 100644
> --- a/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h
> +++ b/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h
> @@ -38,7 +38,7 @@
>    unsigned long int hwcap = __GLRO(dl_hwcap); 			\
>    unsigned long int __attribute__((unused)) hwcap2 = __GLRO(dl_hwcap2); \
>    bool __attribute__((unused)) use_cached_memopt =		\
> -    GLRO(dl_powerpc_cpu_features).use_cached_memopt;		\
> +    __GLRO(dl_powerpc_cpu_features.use_cached_memopt);		\

Agreed.  LGTM.

This is fixing BZ #26615, which was created after you submitted this patch.
I added this information to the patch and pushed as 3322ecbfe2.

Thanks!

-- 
Tulio Magno


More information about the Libc-alpha mailing list