[PATCH] benchtests: Run _Float128 tests only on architectures that support it

Florian Weimer fweimer@redhat.com
Thu Sep 17 08:51:13 GMT 2020


* Arjun Shankar:

> diff --git a/configure.ac b/configure.ac
> index 93e68fb696..7ee79162be 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1821,6 +1821,21 @@ libc_cv_pie_default=$libc_cv_cc_pie_default
>  AC_SUBST(libc_cv_cc_pie_default)
>  AC_SUBST(libc_cv_pie_default)
>  
> +AC_CACHE_CHECK([whether quad-precision floating-point is supported],
> +libc_cv_have_qp_float, [libc_cv_have_qp_float=yes
> +cat > conftest.c <<EOF
> +#include <math.h>
> +#if __HAVE_FLOAT128
> +# error quad-precision floating-point is supported
> +#endif
> +EOF
> +if eval "${CC-cc} -S conftest.c 2>&AS_MESSAGE_LOG_FD 1>&AS_MESSAGE_LOG_FD"; then
> +  libc_cv_have_qp_float=no
> +fi
> +rm -f conftest.*])
> +AC_SUBST(libc_cv_have_qp_float)
> +LIBC_CONFIG_VAR([have-qp-float], [$libc_cv_have_qp_float])

This configure test does not run against <math.h> from the glibc tree,
so its result is not correct.

Please try adding the benchtests via a fragment in
sysdeps/ieee754/float128/Makefile.  I think this won't need additional
configure checks.

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill



More information about the Libc-alpha mailing list