[PATCH] Use size_t for mallinfo fields.

Martin Liška mliska@suse.cz
Wed Sep 2 13:19:06 GMT 2020


On 9/1/20 7:26 PM, Joseph Myers wrote:
> There are several key pieces missing from the mallinfo2 commit.
> 
> * mallinfo2 is not added to GLIBC_2.33 in malloc/Versions.  So it's not
> exported from shared glibc, so it can't actually be used at all.
> 
> * Once a function is exported from shared libc, all the ABI test baselines
> need updating accordingly.
> 
> * Any new function needs a testcase added to the testsuite.  If there were
> such a test, it would have shown up the first problem of the function not
> being exported (that's why there should be tests even for e.g. syscall
> wrappers for syscalls that don't do anything useful as non-root - simply
> testing that it's possible to compile and link a call to each public
> function is useful).
> 
> * Any new function should be mentioned as a new feature in the NEWS file.
> 
> * Any deprecation should be listed under "Deprecated and removed features,
> and other changes affecting compatibility:" in the NEWS file.
> 

Hello.

Thank you for the hints Joseph. There's patch that survives regression tests.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mallinfo2-add-missing-bits.patch
Type: text/x-patch
Size: 4103 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20200902/f903aaf1/attachment.bin>


More information about the Libc-alpha mailing list