[PATCH v2] Reinstate ftime and move define it for POSIX.1-2001 or older

Adhemerval Zanella adhemerval.zanella@linaro.org
Mon Oct 26 16:23:42 GMT 2020



On 26/10/2020 13:19, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> +struct timeb
>> +  {
>> +    time_t time;		/* Seconds since epoch, as from `time'.  */
>> +    unsigned short int millitm;	/* Additional milliseconds.  */
>> +    short int timezone;		/* Minutes west of GMT.  */
>> +    short int dstflag;		/* Nonzero if Daylight Savings Time used.  */
>> +  };
> 
> I think you could add __attribute_deprecated_msg__ on the struct itself.

I tried to add on it, but it would require to add the warning suppression
on ftime.c build before the header inclusion and also on check-local header
tests as well (since it includes).  I think adding on the function itself
should suffice, using the struct without calling ftime should be unusual
scenario. 

> 
> Rest looks okay to me.
> 
> Thanks,
> Florian
> 


More information about the Libc-alpha mailing list