[PATCH 2/2] Revert "linux: Move xmknod{at} to compat symbols"

[Florian Weimer]

* Adhemerval Zanella:

> On 23/10/2020 13:35, Florian Weimer wrote:
>> * Adhemerval Zanella:
>> 
>>> This reverts commit 81b83ff61f95f30ad53d6075247af0ea61a0b16e responsible
>>> to make both __xmknod{at} compatible symbols.
>>>
>>> The idea is to not force static libraries built against old glibc
>>> to update against new glibcs (since they reference the the
>>> xmknod{at} symbols).
>> 
>> I think it's not correct to label this as a revert in the Git sense.
>> At best it's a partial revert.  I tried first to verify this as an
>> actual revert and was wondering if I got the diffing wrong.
>
> Ok, I will change to a partial remove.
>
>> 
>> I think you need to remove libc_hidden_def and libc_hidden_proto around
>> __xmknod, __xmknodat.  “git grep 'libc_hidden.*__xmknod'” should not
>> return anything.  Maybe that should be a separate patch.
>
> If I recall correctly they are still required for Hurd, but I double
> check.  In fact I think we should remove all the io/*xstat* and
> io/*xmknod* since there is no point in providing them as generic
> interfaces.

Then I think you should add the missing libc_hidden_defs instead (to the
Linux implementations).  The present state is inconsistent and
potentially brittle.

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill