[PATCH 3/3] resolv: Handle transaction ID collisions in parallel queries (bug 26600)
Florian Weimer
fweimer@redhat.com
Thu Oct 15 10:35:50 GMT 2020
* Florian Weimer:
> This should fix the crash at least, it's a concurrency bug in the test:
>
> diff --git a/resolv/tst-resolv-txnid-collision.c b/resolv/tst-resolv-txnid-collision.c
> index 611d3736..db9a52b6 100644
> --- a/resolv/tst-resolv-txnid-collision.c
> +++ b/resolv/tst-resolv-txnid-collision.c
> @@ -309,6 +309,7 @@ do_test (void)
> ((struct resolv_redirect_config)
> {
> .response_callback = response,
> + .single_thread_udp = true,
> });
>
> for (int rcode = 0; rcode <= 5; ++rcode)
>
> I doubt it will fix the other test failure, but I'm going to run the
> test over night with this test.
My tests over night looked good, and the above change is clearly needed,
so I have pushed that as commit b8b53b338f6da91e86d115a39da860cefac736ad.
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
More information about the Libc-alpha
mailing list