[PATCH v2 1/9] linux: Move posix dir implementations to Linux

Florian Weimer fweimer@redhat.com
Tue Oct 13 15:33:43 GMT 2020


* Adhemerval Zanella via Libc-alpha:

> This generic implementation already expects a getdents API which
> is Linux specific.  It also allows simplify it by assuming
> _DIRENT_HAVE_D_RECLEN and _DIRENT_HAVE_D_OFF support.
>
> The readdir are also expanded on each required implementation,
> futher fixes and improvements will make parametrize the
> implementation more complex.
>
> Checked on x86_64-linux-gnu, i686-linux-gnu, and with a build
> for all affected ABIs.

This looks okay to me.  It carries forward bug 12165, but that's okay
with me.  (That loop should be removed in a separate patch, although the
code duplication now makes this slightly more work.)

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill



More information about the Libc-alpha mailing list