[PATCH 14/28] elf: Enhance ld.so --help to print HWCAP subdirectories
Matheus Castanho
msc@linux.ibm.com
Fri Oct 9 18:54:19 GMT 2020
On 10/9/20 2:12 PM, Florian Weimer wrote:
> * Florian Weimer via Libc-alpha:
>
>> * Matheus Castanho:
>>
>>> I could reproduce this on both ppc64le and x84_64 with
>>> --disable-tunables. Are we missing an `#include <dl-procinfo.h>`?
>>>
>>> diff --git a/elf/dl-usage.c b/elf/dl-usage.c
>>> index c07f43835b..796ad38b43 100644
>>> --- a/elf/dl-usage.c
>>> +++ b/elf/dl-usage.c
>>> @@ -22,6 +22,7 @@
>>> #include <unistd.h>
>>> #include "version.h"
>>>
>>> +#include <dl-procinfo.h>
>>> #include <dl-hwcaps.h>
>>
>> Right, I think that's what's missing. It's an oversight on my part. I
>> tried build-many-glibcs.py on the whole series, but it doesn't have a
>> configuration without tunables.
>>
>> Would you please post your patch to the list? You can also push it at
>> the same time if you want, I think missing #includes are considered
>> trivial under the check-in policy.
>
> Eh, clearly you have posted this to the list already. It's been a long
> day. 8-/
>
> Please check this in at your convenience. Thanks.
>
> Florian
>
Ok. I'll ask someone to push it for me then. Thanks!
--
Matheus Castanho
More information about the Libc-alpha
mailing list